Add new error source types to RUM schema#1855
Merged
Merged
Conversation
3 tasks
0xnm
approved these changes
Feb 15, 2024
| companion object | ||
| fun fromJson(kotlin.String): RumPerfMetric | ||
| fun fromJsonObject(com.google.gson.JsonObject): RumPerfMetric | ||
| data class com.datadog.android.rum.model.RumVitalEvent |
Member
There was a problem hiding this comment.
this one shouldn't be here, it is not a part of json update for this PR
Member
Author
There was a problem hiding this comment.
Yeah, the fact that it's there is very confusing. I will fix.
fuzzybinary
force-pushed
the
jward/schema-update-2
branch
from
February 15, 2024 15:59
26f2bb0 to
011b9fa
Compare
0xnm
approved these changes
Feb 15, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1855 +/- ##
===========================================
+ Coverage 83.47% 83.50% +0.03%
===========================================
Files 470 470
Lines 16600 16601 +1
Branches 2495 2495
===========================================
+ Hits 13856 13862 +6
+ Misses 2064 2058 -6
- Partials 680 681 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A more condensed version of #1853 the only adds the new error source types to the RUM schema
Review checklist (to be filled by reviewers)