RUM-1702: Start session when RUM is initialized#1832
Merged
0xnm merged 1 commit intoJan 23, 2024
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-1702/start-session-when-rum-is-initialized
branch
from
January 22, 2024 10:46
2c389f1 to
797d76a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1832 +/- ##
===========================================
- Coverage 83.49% 83.45% -0.05%
===========================================
Files 467 467
Lines 16491 16476 -15
Branches 2483 2482 -1
===========================================
- Hits 13769 13749 -20
- Misses 2043 2045 +2
- Partials 679 682 +3
🚀 New features to boost your workflow:
|
0xnm
force-pushed
the
nogorodnikov/rum-1702/start-session-when-rum-is-initialized
branch
from
January 22, 2024 12:24
797d76a to
198cbb6
Compare
0xnm
force-pushed
the
nogorodnikov/rum-1702/start-session-when-rum-is-initialized
branch
from
January 22, 2024 12:29
198cbb6 to
14025c5
Compare
0xnm
marked this pull request as ready for review
January 22, 2024 13:50
fuzzybinary
approved these changes
Jan 22, 2024
fuzzybinary
left a comment
fuzzybinary
left a comment
Member
There was a problem hiding this comment.
This LGTM. Agree we should have @ncreated take a look and make sure the logic is the same.
ncreated
approved these changes
Jan 22, 2024
ncreated
left a comment
ncreated
left a comment
Member
There was a problem hiding this comment.
It looks okay 👍. Good idea to map the new "sdk init" command into existing "app start" to minimise the change impact 👌.
xgouchet
approved these changes
Jan 23, 2024
0xnm
deleted the
nogorodnikov/rum-1702/start-session-when-rum-is-initialized
branch
January 23, 2024 14:37
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change starts RUM session during the
Rum.enablecall. The general rule is like that:foregroundtype, then session will be started (with interaction time set at the moment of initialization), andApplicationLaunchview withapplication_startedevent will be created.foregroundas type, session will be initialized only if background tracking is enabled, noApplicationLaunchview will be created.This PR is using the notion of
SdkInitclass, even though it is possible to use onlyApplicationStartedevent in order to be on-par with the similar logic in iOS SDK. Also it is still using event system for the session initialization in order to minimize the footprint of the change (it will be easier to rollback it if needed).Review checklist (to be filled by reviewers)