Make a copy of attributes before passing them to RUM event#1830
Merged
0xnm merged 1 commit intoJan 22, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1830 +/- ##
===========================================
+ Coverage 83.45% 83.54% +0.09%
===========================================
Files 467 467
Lines 16484 16486 +2
Branches 2482 2483 +1
===========================================
+ Hits 13756 13772 +16
+ Misses 2040 2039 -1
+ Partials 688 675 -13
|
jonathanmos
approved these changes
Jan 21, 2024
xgouchet
approved these changes
Jan 22, 2024
0xnm
deleted the
nogorodnikov/make-a-copy-of-attributes-before-passing-to-rum-event
branch
January 22, 2024 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes a copy of the attributes used by the different RUM events, because usually these attributes are stored in as the shared property of the RUM scope, they could be modified by the RUM thread while being read during the serialization on the I/O thread.
This will eventually prevent
ConcurrentModificationException.Review checklist (to be filled by reviewers)