RUM-1308: Add more HTTP methods to RUM#1826
Merged
Merged
Conversation
xgouchet
approved these changes
Jan 16, 2024
mariusc83
approved these changes
Jan 16, 2024
jonathanmos
approved these changes
Jan 17, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1826 +/- ##
===========================================
- Coverage 83.57% 83.41% -0.16%
===========================================
Files 467 467
Lines 16462 16442 -20
Branches 2480 2475 -5
===========================================
- Hits 13757 13714 -43
- Misses 2033 2042 +9
- Partials 672 686 +14
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1816.
This PR adds support of
CONNECT,TRACE,OPTIONSto theRumMonitor#startResourcecall.Both RUM resources view and traces/spans created by RUM2APM are working fine for these methods.
Review checklist (to be filled by reviewers)