Skip to content

Revert "Merge pull request #1807 from DataDog/mconstantin/rum-2572/fo…#1821

Merged
mariusc83 merged 1 commit into
feature/sr-web-view-supportfrom
mconstantin/drop-force-full-snapshot-logic
Jan 15, 2024
Merged

Revert "Merge pull request #1807 from DataDog/mconstantin/rum-2572/fo…#1821
mariusc83 merged 1 commit into
feature/sr-web-view-supportfrom
mconstantin/drop-force-full-snapshot-logic

Conversation

@mariusc83

@mariusc83 mariusc83 commented Jan 12, 2024

Copy link
Copy Markdown
Member

This reverts commit de212fc, reversing changes made to d02623f.

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
Revert "Merge pull request #1807 from DataDog/mconstantin/rum-2572/fo…
1ad25a8 
…rce-browser-sdk-fullsnapsot-when-context-changed"

This reverts commit de212fc, reversing
changes made to d02623f.
@mariusc83 mariusc83 self-assigned this Jan 12, 2024
@mariusc83
mariusc83 requested review from a team as code owners January 12, 2024 10:16
@codecov-commenter

codecov-commenter commented Jan 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1821 (1ad25a8) into feature/sr-web-view-support (de212fc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@                       Coverage Diff                       @@
##           feature/sr-web-view-support    #1821      +/-   ##
===============================================================
- Coverage                        83.68%   83.66%   -0.02%     
===============================================================
  Files                              472      471       -1     
  Lines                            16527    16501      -26     
  Branches                          2478     2473       -5     
===============================================================
- Hits                             13830    13805      -25     
+ Misses                            2016     2011       -5     
- Partials                           681      685       +4
Files Coverage Δ
...dog/android/sessionreplay/SessionReplayRecorder.kt 94.74% <100.00%> (-0.07%) ⬇️
...essionreplay/internal/recorder/SnapshotProducer.kt 87.88% <ø> (-3.79%) ⬇️

... and 27 files with indirect coverage changes

@mariusc83
mariusc83 merged commit 08668d7 into feature/sr-web-view-support Jan 15, 2024
@mariusc83
mariusc83 deleted the mconstantin/drop-force-full-snapshot-logic branch January 15, 2024 08:44
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mariusc83 mariusc83

Labels

None yet

Projects

None yet

Milestone

2.8.x

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @xgouchet @0xnm