Skip to content

RUM-2746: Add additional status codes as retryable#1819

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-2746/add-more-status-codes-as-retryable
Jan 15, 2024
Merged

RUM-2746: Add additional status codes as retryable#1819
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-2746/add-more-status-codes-as-retryable

Conversation

@0xnm

@0xnm 0xnm commented Jan 12, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds additional status codes which we can get from intake as retryable in order to prevent data loss:

  • 502 - bad gateway
  • 504 - gateway timeout
  • 507 - insufficient storage

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners January 12, 2024 09:02
@0xnm
0xnm force-pushed the nogorodnikov/rum-2746/add-more-status-codes-as-retryable branch from 8d3804c to dce698f Compare January 12, 2024 14:08
@codecov-commenter

codecov-commenter commented Jan 12, 2024

Copy link
Copy Markdown

Codecov Report

Merging #1819 (dce698f) into develop (b8dc955) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1819      +/-   ##
===========================================
- Coverage    83.55%   83.50%   -0.05%     
===========================================
  Files          467      467              
  Lines        16466    16455      -11     
  Branches      2482     2482              
===========================================
- Hits         13757    13740      -17     
- Misses        2030     2037       +7     
+ Partials       679      678       -1     
Files Coverage Δ
...id/core/internal/data/upload/DataOkHttpUploader.kt 93.98% <100.00%> (+1.12%) ⬆️

... and 23 files with indirect coverage changes

@0xnm
0xnm merged commit c098d3a into develop Jan 15, 2024
@0xnm
0xnm deleted the nogorodnikov/rum-2746/add-more-status-codes-as-retryable branch January 15, 2024 08:29
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants