fix: getCurrentSessionId returns correct value#1817
Merged
Conversation
0xnm
approved these changes
Jan 10, 2024
fuzzybinary
force-pushed
the
jward/RUM-1962-session-id-acessor
branch
from
January 10, 2024 16:57
77c852d to
34221a2
Compare
refs: RUM-1962
fuzzybinary
force-pushed
the
jward/RUM-1962-session-id-acessor
branch
from
January 10, 2024 17:02
34221a2 to
c0b2f35
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1817 +/- ##
===========================================
+ Coverage 83.38% 83.46% +0.08%
===========================================
Files 466 466
Lines 16388 16370 -18
Branches 2456 2461 +5
===========================================
- Hits 13665 13663 -2
+ Misses 2045 2031 -14
+ Partials 678 676 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix getCurrentSessionId to actually return the correct session id for the currently active session.
refs: RUM-1962
Review checklist (to be filled by reviewers)