Skip to content

RUM-1520 prevent false positive warning#1815

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-1520/remove_warning
Jan 9, 2024
Merged

RUM-1520 prevent false positive warning#1815
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-1520/remove_warning

Conversation

@xgouchet

@xgouchet xgouchet commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Prevent a false positive warning in the logcat when the logs feature is available but no fields is provided to the span.log() method

@xgouchet
xgouchet requested review from a team as code owners January 9, 2024 09:57
@codecov-commenter

codecov-commenter commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (88069eb) to head (a32ff40).
⚠️ Report is 2790 commits behind head on develop.

Files with missing lines Patch % Lines
.../trace/internal/handlers/AndroidSpanLogsHandler.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1815      +/-   ##
===========================================
- Coverage    83.52%   83.45%   -0.07%     
===========================================
  Files          466      466              
  Lines        16368    16364       -4     
  Branches      2455     2452       -3     
===========================================
- Hits         13670    13656      -14     
- Misses        2028     2036       +8     
- Partials       670      672       +2     
Files with missing lines Coverage Δ
.../trace/internal/handlers/AndroidSpanLogsHandler.kt 87.76% <0.00%> (-1.83%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet
xgouchet merged commit a2757af into develop Jan 9, 2024
@xgouchet
xgouchet deleted the xgouchet/RUM-1520/remove_warning branch January 9, 2024 14:08
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants