Move reading BUILDENV_HOST_IP variable to the job script definition#1801
Merged
Merged
Conversation
0xnm
changed the title
0xnm
changed the title
BUILDENV_HOST_IP variable to the job script definition
0xnm
force-pushed
the
nogorodnikov/move-setting-dd-agent-host-to-stage
branch
from
January 2, 2024 13:37
8783e4d to
4c92f31
Compare
0xnm
marked this pull request as ready for review
January 2, 2024 13:55
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1801 +/- ##
===========================================
+ Coverage 83.41% 83.51% +0.11%
===========================================
Files 466 466
Lines 16371 16348 -23
Branches 2453 2454 +1
===========================================
- Hits 13655 13653 -2
+ Misses 2041 2031 -10
+ Partials 675 664 -11 |
jonathanmos
approved these changes
Jan 3, 2024
mariusc83
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We've changed the runner type here #1789 and since it is now k8s-based, the variables that depends on information related to k8s resources (host IP) needs to be referenced directly from the job otherwise is not going to work.
This PR fixes
dd-trace-javabootstrap which was failing, becauseBUILDENV_HOST_IPwasn't available at thevariablesset stage.Review checklist (to be filled by reviewers)