RUM-2314 Fix ConcurrentModificationException in BitmapPool#1798
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1798 +/- ##
===========================================
+ Coverage 83.42% 83.49% +0.07%
===========================================
Files 466 466
Lines 16371 16363 -8
Branches 2454 2450 -4
===========================================
+ Hits 13657 13662 +5
- Misses 2039 2041 +2
+ Partials 675 660 -15
|
jonathanmos
marked this pull request as ready for review
January 1, 2024 15:59
0xnm
reviewed
Jan 2, 2024
mariusc83
approved these changes
Jan 2, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-2314/bitmap-pool-exception
branch
from
January 2, 2024 09:22
8c91847 to
39d9e24
Compare
0xnm
approved these changes
Jan 2, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-2314/bitmap-pool-exception
branch
from
January 2, 2024 09:56
39d9e24 to
e2a50d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a ConcurrentModificationException that can occur due a race condition between low memory evicting items from the cache, and threads attempting to query the cache.
Motivation
What inspired you to submit this pull request?
Additional Notes
3000 iterations is the lower bound to reliably reproduce the issue in a reasonable number of unit test runs when it exists. This number of iterations takes around 4 seconds to run locally.
Review checklist (to be filled by reviewers)