Add telemetry point for null file content#1792
Merged
0xnm merged 1 commit intoDec 28, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1792 +/- ##
===========================================
- Coverage 83.64% 83.37% -0.28%
===========================================
Files 466 466
Lines 16368 16372 +4
Branches 2451 2452 +1
===========================================
- Hits 13691 13649 -42
- Misses 2023 2044 +21
- Partials 654 679 +25
|
xgouchet
approved these changes
Dec 28, 2023
mariusc83
approved these changes
Dec 28, 2023
0xnm
deleted the
nogorodnikov/add-telemetry-point-for-null-file-content
branch
December 28, 2023 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an additional telemetry point for the issue, when sometimes file content is only "\u0000" (happens when we decode information for NDK crash submission).
I didn't manage to understand why it happens. In theory if decoding from bytes to string fails, broken chars should be mapped to
\ufffd, but to validate the assumption that the issue is on during decoding I'm adding this.Review checklist (to be filled by reviewers)