RUM-2604: Fix view url in case of NavigationViewTrackingStrategy usage#1791
Merged
0xnm merged 1 commit intoDec 28, 2023
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-2604/fix-view-url-in-case-of-navigation-view-tracking-strategy
branch
from
December 27, 2023 14:22
6050dbc to
62bad44
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1791 +/- ##
===========================================
- Coverage 83.64% 83.49% -0.16%
===========================================
Files 466 466
Lines 16368 16295 -73
Branches 2451 2440 -11
===========================================
- Hits 13691 13604 -87
- Misses 2023 2030 +7
- Partials 654 661 +7
|
xgouchet
approved these changes
Dec 28, 2023
mariusc83
approved these changes
Dec 28, 2023
0xnm
deleted the
nogorodnikov/rum-2604/fix-view-url-in-case-of-navigation-view-tracking-strategy
branch
December 28, 2023 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a bug originally introduced in
1.17.2with the following commit: since we didn't have a specialNavigationKeyhandling in theAny.resolveViewUrlmethod, view URL was always displayed ascom/datadog/android/rum/tracking/NavigationViewTrackingStrategy/NavigationKey.Also the key used between
stopViewandstartViewcalls inNavigationViewTrackingStrategywas different because of this bug (NavDestinationvsNavigationKeyrespectively)Review checklist (to be filled by reviewers)