Add delay before executors are flushed and stopped in nightly tests#1783
Merged
0xnm merged 1 commit intoDec 22, 2023
Merged
Conversation
xgouchet
approved these changes
Dec 21, 2023
0xnm
force-pushed
the
nogorodnikov/add-delay-before-executors-are-stopped-in-nightly-tests
branch
from
December 21, 2023 15:35
cc4a5d2 to
3785409
Compare
xgouchet
approved these changes
Dec 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1783 +/- ##
===========================================
- Coverage 83.47% 83.43% -0.04%
===========================================
Files 466 466
Lines 16364 16364
Branches 2452 2452
===========================================
- Hits 13659 13652 -7
+ Misses 2039 2037 -2
- Partials 666 675 +9 |
mariusc83
approved these changes
Dec 22, 2023
0xnm
deleted the
nogorodnikov/add-delay-before-executors-are-stopped-in-nightly-tests
branch
December 22, 2023 09:05
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current logic of stopping executors and flushing data after each nightly test is not reliable, because in case of RUM we have a backward loop which cannot be executed if executors are stopped.
This PR adds a delay, so that all the events possibly can get processed.
Review checklist (to be filled by reviewers)