Fix leak caused by repeated calls to WeakReference.get()#1779
Merged
Conversation
If the view is already stopped, there's no need to determine whether it needs to be stopped. See #1762
xgouchet
approved these changes
Dec 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1779 +/- ##
===========================================
+ Coverage 83.36% 83.41% +0.05%
===========================================
Files 465 465
Lines 16348 16349 +1
Branches 2456 2457 +1
===========================================
+ Hits 13627 13636 +9
+ Misses 2047 2039 -8
Partials 674 674
|
This was referenced Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of commit from #1763 in our repo, to be able to run all the checks.
Review checklist (to be filled by reviewers)