Conversation
…pe completes with an error
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1776 +/- ##
===========================================
+ Coverage 83.46% 83.60% +0.13%
===========================================
Files 469 469
Lines 16431 16435 +4
Branches 2465 2467 +2
===========================================
+ Hits 13714 13739 +25
+ Misses 2038 2027 -11
+ Partials 679 669 -10
|
mariusc83
reviewed
Dec 20, 2023
| val entry = iterator.next() | ||
| val scope = entry.value.handleEvent(event, writer) | ||
| if (scope == null) { | ||
| // if we finalized this scope and it was by error, we won't have resource |
mariusc83
approved these changes
Dec 20, 2023
jonathanmos
approved these changes
Dec 20, 2023
0xnm
deleted the
nogorodnikov/rum-2566/convert-pending-resource-to-pending-error-when-resource-completes-with-an-error
branch
December 20, 2023 11:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is a following bug: we increate
RumViewScope#pendingResourceCountwhen we create resource scope, but resource scope can be finalized with 2 outcomes: either resource event or error event. In latter case we should instead decreasependingResourceCountand increasependingErrorCount, becauseResourceSent/ResourceDroppedwill never be sent and we get insteadErrorSent/ErrorDropped.Review checklist (to be filled by reviewers)