Skip to content

Add text overflow examples in sample app#1775

Merged
louiszawadzki merged 1 commit into
developfrom
louiszawadzki/rum-2354/add-sr-text-scenarios-to-sample-app
Dec 20, 2023
Merged

Add text overflow examples in sample app#1775
louiszawadzki merged 1 commit into
developfrom
louiszawadzki/rum-2354/add-sr-text-scenarios-to-sample-app

Conversation

@louiszawadzki

Copy link
Copy Markdown
Contributor

What does this PR do?

Add text overflow examples in sample app. These example overflow in the replays. Now that they're added they will be easier to check on when we apply the fix.

Emulator Replay
image image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@louiszawadzki
louiszawadzki requested review from a team as code owners December 19, 2023 15:51
@codecov-commenter

codecov-commenter commented Dec 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1775 (ce6e011) into develop (2716cb6) will increase coverage by 0.15%.
Report is 6 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1775      +/-   ##
===========================================
+ Coverage    83.42%   83.57%   +0.15%     
===========================================
  Files          469      469              
  Lines        16434    16434              
  Branches      2454     2454              
===========================================
+ Hits         13710    13734      +24     
+ Misses        2053     2033      -20     
+ Partials       671      667       -4     

see 20 files with indirect coverage changes

@louiszawadzki
louiszawadzki merged commit 3947313 into develop Dec 20, 2023
@louiszawadzki
louiszawadzki deleted the louiszawadzki/rum-2354/add-sr-text-scenarios-to-sample-app branch December 20, 2023 14:42
@xgouchet xgouchet added this to the 2.4.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants