Remove the v1 data upload components#1774
Merged
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/remove-v1-upload-package
branch
from
December 19, 2023 15:10
202bd74 to
26694c0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1774 +/- ##
===========================================
- Coverage 83.46% 83.41% -0.05%
===========================================
Files 469 465 -4
Lines 16431 16348 -83
Branches 2465 2456 -9
===========================================
- Hits 13714 13636 -78
- Misses 2038 2039 +1
+ Partials 679 673 -6
|
0xnm
approved these changes
Dec 19, 2023
Comment on lines
+12
to
+13
| // TODO RUMM-0000 Should replace com.datadog.android.core.internal.net.Flusher once | ||
| // features are configured as V2 |
Member
There was a problem hiding this comment.
seems like this comment is not relevant anymore?
mariusc83
force-pushed
the
mconstantin/remove-v1-upload-package
branch
from
December 20, 2023 08:03
26694c0 to
a66b9af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)