RUM-1520 Add all Logs Feature integration tests#1769
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-logs
branch
from
December 15, 2023 15:31
105c9ec to
8da8d33
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1769 +/- ##
===========================================
+ Coverage 83.40% 83.44% +0.04%
===========================================
Files 469 469
Lines 16408 16408
Branches 2449 2449
===========================================
+ Hits 13685 13691 +6
+ Misses 2052 2046 -6
Partials 671 671 |
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-logs
branch
from
December 15, 2023 17:04
8da8d33 to
e33ff12
Compare
0xnm
approved these changes
Dec 18, 2023
|
|
||
| override fun registerFeature(feature: Feature) { | ||
| // Stop previous registered | ||
| featureScopes[feature.name]?.unwrap<Feature>()?.onStop() |
Member
There was a problem hiding this comment.
shouldn't we just stop core instead after each test? and stop the features in the stop method of the code.
Contributor
Author
There was a problem hiding this comment.
This part is only required because in one of the tests I override the previously started feature: in the @BeforeEach set up, we register a Logs feature, but in some tests I need to register a feature with a different configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add integration tests covering all the Logs Feature apis
Motivation
Reliability, reliability, reliability