RUM-2568: Better handling of event write errors in RUM#1766
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1766 +/- ##
========================================
Coverage 83.68% 83.68%
========================================
Files 465 466 +1
Lines 16336 16364 +28
Branches 2454 2452 -2
========================================
+ Hits 13670 13694 +24
Misses 2017 2017
- Partials 649 653 +4
🚀 New features to boost your workflow:
|
0xnm
force-pushed
the
nogorodnikov/handle-event-write-errors-in-rum
branch
from
December 19, 2023 17:24
3501939 to
f04c90a
Compare
0xnm
changed the base branch from
develop
to
nogorodnikov/rum-2566/convert-pending-resource-to-pending-error-when-resource-completes-with-an-error
December 19, 2023 17:24
0xnm
changed the title
Base automatically changed from
nogorodnikov/rum-2566/convert-pending-resource-to-pending-error-when-resource-completes-with-an-error
to
develop
December 20, 2023 11:03
0xnm
force-pushed
the
nogorodnikov/handle-event-write-errors-in-rum
branch
3 times, most recently
from
December 20, 2023 16:05
f04c90a to
54d41c6
Compare
0xnm
marked this pull request as ready for review
December 20, 2023 16:07
mariusc83
approved these changes
Dec 21, 2023
jonathanmos
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves any error handling in the write pipeline of RUM. Before, if there was any exception thrown inside writing pipeline which wasn't caught, or if write wasn't successful, we didn't notify that event wasn't written (or dropped, in other words). This prevented to decrease
pendingXXXcounters inRumViewScope, thus makingisCompleteto evaluate tofalsein such cases.This PR also centralizes the place where the notification about write success or failure is sent.
Review checklist (to be filled by reviewers)