Fix leak caused by repeated calls to WeakReference.get()#1763
Closed
pyricau wants to merge 12 commits into
Closed
Conversation
…a3-release Prepare release of `2.0.0-beta3`
…0-release Prepare release of 2.0.0
…e-2-0-0-to-master Merge release v2.0.0
…-into-master Merge release 2.1.0 into master branch
Merge release 2.2.0 branch into master
…se-2.3.0-into-master Merge `release/2.3.0` branch into `master` branch
If the view is already stopped, there's no need to determine whether it needs to be stopped. See DataDog#1762
mariusc83
approved these changes
Dec 18, 2023
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
Tks for taking the time for this fix.
xgouchet
approved these changes
Dec 18, 2023
Contributor
|
Thanks a lot for your contribution @pyricau in order for us to merge this PR, we need have two requirements to be met:
|
3 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the view is already stopped, there's no need to determine whether it needs to be stopped.
See #1762