RUM-2376: Fix duplicate wireframes issue#1761
Merged
jonathanmos merged 1 commit intoDec 15, 2023
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-2376/fix-duplicate-wireframes-issue
branch
from
December 14, 2023 08:39
db93f61 to
b1d86ea
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1761 +/- ##
===========================================
+ Coverage 83.43% 83.56% +0.12%
===========================================
Files 469 469
Lines 16394 16401 +7
Branches 2448 2448
===========================================
+ Hits 13678 13704 +26
+ Misses 2048 2029 -19
Partials 668 668
|
jonathanmos
marked this pull request as ready for review
December 14, 2023 09:07
0xnm
approved these changes
Dec 14, 2023
xgouchet
approved these changes
Dec 14, 2023
jonathanmos
force-pushed
the
jmoskovich/rum-2376/fix-duplicate-wireframes-issue
branch
from
December 14, 2023 15:33
2dadc22 to
559c763
Compare
jonathanmos
deleted the
jmoskovich/rum-2376/fix-duplicate-wireframes-issue
branch
December 15, 2023 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pr fixes the issue of duplicate wireframes appearing in the replays, and also adds in telemetry so that we'll know if items are dropped in future from the
RecordedDataQueue.What was happening was that
RecordedDataQueueRefswas held as a class-level variable insideRecordedDataQueueHandler. As a result, for every traversal the value of theSnapshotRecordedDataQueueItemheld by the ref object was mutating, and this caused asynchronous tasks to occasionally return their callback to the wrongSnapshotRecordedDataQueueItem. This further led to the number of pending asynchronous tasks on the previous item never reaching zero, so it became stuck in the queue and eventually cleaned after exceeding the 200ms timeout.Motivation
To handle the issue of duplicate wireframes.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)