RUM-451 Update RUM attributes in spans#1758
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1758 +/- ##
===========================================
+ Coverage 83.34% 83.42% +0.09%
===========================================
Files 468 468
Lines 16304 16304
Branches 2431 2433 +2
===========================================
+ Hits 13587 13601 +14
+ Misses 2050 2035 -15
- Partials 667 668 +1
🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
Dec 11, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add RUM info in new builtin attributes on spans.
Motivation
The APM UI expects RUM information to be in the following attributes in order to add a visual link to the RUM Session/View.
meta._dd.application.idmeta._dd.view.idmeta._dd.session.idAdditional Notes
We are still keeping the legacy attributes which already had those information for compatibility purposes (e.g.: customer using those to query/filter dashboard widgets)