RUM-2446: Open text masking classes for extension#1757
Merged
jonathanmos merged 1 commit intoDec 11, 2023
Conversation
jonathanmos
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1757 +/- ##
===========================================
- Coverage 83.34% 83.29% -0.05%
===========================================
Files 468 468
Lines 16304 16301 -3
Branches 2431 2430 -1
===========================================
- Hits 13587 13577 -10
- Misses 2050 2057 +7
Partials 667 667
|
jonathanmos
marked this pull request as ready for review
December 11, 2023 08:41
xgouchet
approved these changes
Dec 11, 2023
0xnm
approved these changes
Dec 11, 2023
jonathanmos
deleted the
jmoskovich/rum-2446/open-text-masking-for-extension
branch
December 11, 2023 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify
MaskTextViewMapperandMaskInputTextViewMapperto be open for extension.Motivation
Necessary for React Native Session Replay, in order to support masking for text elements.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)