Skip to content

Remove resourceId field from e2e payloads#1754

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-resourceid-e2e
Dec 6, 2023
Merged

Remove resourceId field from e2e payloads#1754
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-resourceid-e2e

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

Adds resourceIds to the e2e payloads

Motivation

We now send resourceIds as part of the ImageWireframes

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1754 (7ca6f1b) into develop (f38f6be) will increase coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1754      +/-   ##
===========================================
+ Coverage    83.34%   83.43%   +0.10%     
===========================================
  Files          468      468              
  Lines        16304    16301       -3     
  Branches      2431     2430       -1     
===========================================
+ Hits         13587    13600      +13     
+ Misses        2050     2034      -16     
  Partials       667      667              

see 22 files with indirect coverage changes

@jonathanmos
jonathanmos marked this pull request as ready for review December 6, 2023 14:42
@jonathanmos
jonathanmos requested review from a team as code owners December 6, 2023 14:42

@maciejburda maciejburda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm

0xnm commented Dec 6, 2023

Copy link
Copy Markdown
Member

I'm not sure this is the right approach, because when we currently validate data we drop base64 property here. resourceId property also relies on the drawable content, the same way as base64 (essentially they are using the same input, correct me if I'm wrong), so since input for base64 is considered as inconsistent, we should also remove resourceId from the validation instead of adding it to the json. WDYT?

@jonathanmos
jonathanmos force-pushed the jmoskovich/fix-resourceid-e2e branch from 7ca6f1b to 2b2d3d6 Compare December 6, 2023 16:26
@jonathanmos

Copy link
Copy Markdown
Member Author

I'm not sure this is the right approach, because when we currently validate data we drop base64 property here. resourceId property also relies on the drawable content, the same way as base64 (essentially they are using the same input, correct me if I'm wrong), so since input for base64 is considered as inconsistent, we should also remove resourceId from the validation instead of adding it to the json. WDYT?

Yes, I recall now. Marius had failures on CI because of the variability - good catch. I've changed to remove the resourceId field

@jonathanmos jonathanmos changed the title Add resourceIds to payloads Remove resourceId field from e2e payloads Dec 6, 2023
@jonathanmos
jonathanmos merged commit bece8a1 into develop Dec 6, 2023
@jonathanmos
jonathanmos deleted the jmoskovich/fix-resourceid-e2e branch December 6, 2023 16:54
@xgouchet xgouchet added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants