(4/4) RUM-2129 Use AbstractStorage when custom persistence strategy provided#1748
Merged
Merged
Conversation
0xnm
reviewed
Nov 28, 2023
| persistenceStrategyFactory: PersistenceStrategy.Factory | ||
| ): Storage { | ||
| return AbstractStorage( | ||
| coreFeature.variant, |
Member
There was a problem hiding this comment.
it seems it should be sdkCoreId here rather than coreFeature.variant?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1748 +/- ##
===========================================
+ Coverage 83.23% 83.42% +0.19%
===========================================
Files 467 467
Lines 16242 16258 +16
Branches 2418 2419 +1
===========================================
+ Hits 13518 13562 +44
+ Misses 2056 2035 -21
+ Partials 668 661 -7
🚀 New features to boost your workflow:
|
Base automatically changed from
xgouchet/RUM-2129/3_custom_persistence_mgt
to
develop
November 29, 2023 11:21
jonathanmos
approved these changes
Dec 4, 2023
xgouchet
force-pushed
the
xgouchet/RUM-2129/4_custom_persistence_mgt
branch
from
December 4, 2023 10:58
9094892 to
05055cf
Compare
0xnm
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been created automatically by splitting a large branch
Pull request 4 out of 4
This final PR updates the SDK Feature initialisation by choosing the default storage or the new
AbstractStorageone depending on the providedPersistenceStrategy.Factory