(2/4) RUM-2129 let customer set custom persistence strategy in configuration#1746
Merged
Merged
Conversation
When set, this will be reported in the configuration telemetry, and the persistenceStrategyFactory will be store in the CoreFeature instance
0xnm
reviewed
Nov 28, 2023
| fun setAdditionalConfiguration(Map<String, Any>): Builder | ||
| fun setProxy(java.net.Proxy, okhttp3.Authenticator?): Builder | ||
| fun setEncryption(com.datadog.android.security.Encryption): Builder | ||
| fun setPersistenceStrategyFactory(com.datadog.android.core.persistence.PersistenceStrategy.Factory?): Builder |
Member
There was a problem hiding this comment.
Should we hide it behind some internal proxy? I was thinking that we are not going to show this method to everyone.
Contributor
Author
There was a problem hiding this comment.
The thing is that we don't have an internal proxy for the configuration. The fact that the interface to implement is not trivial at all makes me think that no one (if they discover it) will bother implementing it
jonathanmos
approved these changes
Nov 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1746 +/- ##
===========================================
- Coverage 83.37% 83.29% -0.07%
===========================================
Files 466 466
Lines 16183 16189 +6
Branches 2411 2412 +1
===========================================
- Hits 13491 13484 -7
- Misses 2036 2043 +7
- Partials 656 662 +6
|
Base automatically changed from
xgouchet/RUM-2129/1_custom_persistence_mgt
to
develop
November 29, 2023 09:36
0xnm
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been created automatically by splitting a large branch
Pull request 2 out of 4
This PR adds the necessary methods to set a custom
PersistenceStrategy.Factoryin the core configuration.When set, this will be reported in the configuration telemetry, and
the persistenceStrategyFactory will be stored in the CoreFeature instance