RUM-2259 Fix flaky test in WireframeUtils#1743
Merged
Merged
Conversation
xgouchet
changed the title
For some reason, we expected in the test a value of `0L` to be converted to `null`, but it doesn't happen in the implementation, leading to fail assertions in rare cases when one of the clip values is `0L`.
xgouchet
force-pushed
the
xgouchet/flaky/wireframe
branch
from
November 23, 2023 14:29
b7ead90 to
c1b0d1b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1743 +/- ##
===========================================
+ Coverage 83.35% 83.39% +0.05%
===========================================
Files 465 465
Lines 16182 16179 -3
Branches 2412 2411 -1
===========================================
+ Hits 13487 13492 +5
+ Misses 2040 2025 -15
- Partials 655 662 +7 |
jonathanmos
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, we expected in the test a value of
0Lto be converted tonull, but it doesn't happen in the implementation, leading to fail assertions in rare cases when one of the clip values is0L.