RUM-2245 Generate wireframe ids as 32bit Int#1736
Merged
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-2245/wireframe-id-as-int
branch
2 times, most recently
from
November 21, 2023 12:09
3957178 to
9f5da2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1736 +/- ##
===========================================
- Coverage 83.35% 83.31% -0.04%
===========================================
Files 465 465
Lines 16182 16182
Branches 2412 2412
===========================================
- Hits 13487 13481 -6
- Misses 2031 2039 +8
+ Partials 664 662 -2
🚀 New features to boost your workflow:
|
jonathanmos
force-pushed
the
jmoskovich/rum-2245/wireframe-id-as-int
branch
from
November 21, 2023 12:40
9f5da2b to
f6b7d37
Compare
jonathanmos
marked this pull request as ready for review
November 21, 2023 12:40
mariusc83
approved these changes
Nov 21, 2023
0xnm
approved these changes
Nov 21, 2023
xgouchet
approved these changes
Nov 21, 2023
jonathanmos
force-pushed
the
jmoskovich/rum-2245/wireframe-id-as-int
branch
from
November 21, 2023 13:13
f6b7d37 to
21b12e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generates wireframe IDs as
Intinstead of asLong. Also modify the forgery factories to do the same so that tests will reflect this change.Motivation
Generating the IDs as
Longcaused an issue on the backend because there the IDs are being parsed asInt. When the ID was out of bounds it would be rounded and this could cause problems with removals of wireframes or duplicated wireframes.Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)