RUM-1520 Logger integration tests#1735
Merged
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-1517/stub_sdk_core
branch
from
November 20, 2023 13:54
e34a781 to
714bbec
Compare
0xnm
approved these changes
Nov 20, 2023
|
|
||
| // Then | ||
| val eventsWritten: List<StubEvent> = stubSdkCore.eventsWritten(Feature.LOGS_FEATURE_NAME) | ||
| assertThat(eventsWritten).hasSize(0) |
Member
There was a problem hiding this comment.
minor: usage of isEmpty here will give more descriptive message in case of failure
| val eventsWritten: List<StubEvent> = stubSdkCore.eventsWritten(Feature.LOGS_FEATURE_NAME) | ||
| assertThat(eventsWritten).hasSize(1) | ||
| val event0 = JsonParser.parseString(eventsWritten[0].eventData) as JsonObject | ||
| println(event0) |
Member
There was a problem hiding this comment.
seems some debugging leftover (also there are more occurrences down the file)
xgouchet
force-pushed
the
xgouchet/RUM-1520/single-fit-logs
branch
from
November 21, 2023 09:22
ccf533b to
c46c81e
Compare
jonathanmos
approved these changes
Nov 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1735 +/- ##
========================================
Coverage 83.35% 83.35%
========================================
Files 465 465
Lines 16182 16179 -3
Branches 2412 2411 -1
========================================
- Hits 13487 13485 -2
- Misses 2031 2037 +6
+ Partials 664 657 -7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates the first real Integration Test class for the
LoggerandLogger.Builderclasses.So far overal public API (all modules together) is up to 4%