Fix flaky test in BatchFileOrchestratorTest#1732
Merged
Merged
Conversation
0xnm
approved these changes
Nov 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1732 +/- ##
===========================================
- Coverage 83.41% 83.32% -0.09%
===========================================
Files 465 465
Lines 16173 16170 -3
Branches 2407 2406 -1
===========================================
- Hits 13490 13473 -17
- Misses 2027 2041 +14
Partials 656 656 |
mariusc83
approved these changes
Nov 17, 2023
| Thread { | ||
| val result = testedOrchestrator.getRootDir() | ||
| results.add(result) | ||
| synchronized(results) { results.add(result) } |
Member
There was a problem hiding this comment.
ohh nice catch...good to know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix flaky test in BatchFileOrchestratorTest
The main issue here is that were using Kotlin's
mutableListOf()which is inherently not thread safe, and try to insert elements from multiple concurrent threads. What happens 10% of the time (locally) is that two thread end up appending at the same time, and one of the value is overridden, resulting in one less value in the list than expected.