Fix flaky test in TelemetryEventHandlerTest#1729
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1729 +/- ##
===========================================
- Coverage 83.41% 83.35% -0.06%
===========================================
Files 465 465
Lines 16147 16144 -3
Branches 2401 2400 -1
===========================================
- Hits 13468 13456 -12
- Misses 2025 2033 +8
- Partials 654 655 +1 |
0xnm
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a flaky test in TelemetryEventHandlerTest
The test generates a list of events, and then filters it to ensure to keep only one event per fingerprint. If the number of filtered event is lower than the
MAX_EVENTS_PER_SESSION_TESTvalue, the test eventually tries to verify that a warning log is printed a negative amount of times.The fix ensures that the filtered list has enough entries to trigger the log at least once.