Fix flaky test in DatadogContextProvider#1726
Merged
Merged
Conversation
0xnm
approved these changes
Nov 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1726 +/- ##
===========================================
- Coverage 83.41% 83.31% -0.10%
===========================================
Files 465 465
Lines 16092 16089 -3
Branches 2386 2385 -1
===========================================
- Hits 13422 13404 -18
- Misses 2025 2047 +22
+ Partials 645 638 -7 |
mariusc83
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a flaky test in the DatadogContextProvider:
the test tries to ensure modifying a mutable map after it being injected won't modify the underlying context.
In some rare case, the following line would create an issue, as no data would be removed from the mutable map, making one of the assertions failed.
The fix ensures that: