RUM-1017: Unregister RUM monitor when associated RUM feature is stopped#1725
Merged
0xnm merged 1 commit intoNov 16, 2023
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-1017/clean-up-registered-rum-monitor-when-rum-feature-is-stopped
branch
from
November 16, 2023 09:43
7f0cf88 to
ae0408f
Compare
xgouchet
approved these changes
Nov 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1725 +/- ##
===========================================
- Coverage 83.41% 83.38% -0.02%
===========================================
Files 465 465
Lines 16092 16093 +1
Branches 2386 2385 -1
===========================================
- Hits 13422 13419 -3
- Misses 2025 2035 +10
+ Partials 645 639 -6
|
mariusc83
approved these changes
Nov 16, 2023
0xnm
deleted the
nogorodnikov/rum-1017/clean-up-registered-rum-monitor-when-rum-feature-is-stopped
branch
November 16, 2023 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change removes RUM monitor for the given RUM feature (or SDK instance in other words), when the feature is stopped.
Review checklist (to be filled by reviewers)