Skip to content

(5/9) RUM-2127 Add synthetics info to RUM Actions#1718

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-2127/5_read_synthetics_info
Nov 16, 2023
Merged

(5/9) RUM-2127 Add synthetics info to RUM Actions#1718
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-2127/5_read_synthetics_info

Conversation

@xgouchet

@xgouchet xgouchet commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

This PR has been created automatically by the CI

Add synthetics info to RUM Actions
The info is read from the RUM context and converted into the relevant attributes at write time.

@xgouchet
xgouchet requested review from a team as code owners November 15, 2023 09:41
@codecov-commenter

codecov-commenter commented Nov 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1718 (69f9cfd) into develop (33ebc18) will increase coverage by 0.07%.
Report is 1 commits behind head on develop.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1718      +/-   ##
===========================================
+ Coverage    83.30%   83.36%   +0.07%     
===========================================
  Files          465      465              
  Lines        16103    16125      +22     
  Branches      2389     2395       +6     
===========================================
+ Hits         13413    13442      +29     
  Misses        2038     2038              
+ Partials       652      645       -7     
Files Coverage Δ
...ndroid/rum/internal/domain/scope/RumActionScope.kt 96.47% <83.33%> (-1.01%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.75% <83.33%> (-0.07%) ⬇️

... and 22 files with indirect coverage changes

sdkCore.getFeature(Feature.RUM_FEATURE_NAME)
?.withWriteContext { datadogContext, eventBatchWriter ->
val user = datadogContext.userInfo
val syntheticsAttribute = if (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@xgouchet
xgouchet force-pushed the xgouchet/RUM-2127/4_read_synthetics_info branch 2 times, most recently from e553692 to 33ebc18 Compare November 16, 2023 09:30
@xgouchet
xgouchet force-pushed the xgouchet/RUM-2127/5_read_synthetics_info branch from a5916fe to 69f9cfd Compare November 16, 2023 09:38
Base automatically changed from xgouchet/RUM-2127/4_read_synthetics_info to develop November 16, 2023 09:59
@xgouchet
xgouchet merged commit 436fad3 into develop Nov 16, 2023
@xgouchet
xgouchet deleted the xgouchet/RUM-2127/5_read_synthetics_info branch November 16, 2023 10:50
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants