Skip to content

Include rum-mobile-android as codeowner#1695

Merged
plousada merged 1 commit into
developfrom
plousada/include_rum_mobile_android_codeowner
Nov 13, 2023
Merged

Include rum-mobile-android as codeowner#1695
plousada merged 1 commit into
developfrom
plousada/include_rum_mobile_android_codeowner

Conversation

@plousada

@plousada plousada commented Nov 13, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This PR includes the rum-mobile-android team as a code owning team in order to ensure we have at least 1 Android Engineer reviewing every merged PR.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada
plousada requested a review from a team as a code owner November 13, 2023 11:36
@codecov-commenter

codecov-commenter commented Nov 13, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.69%. Comparing base (7e80c37) to head (13d59f2).
⚠️ Report is 2057 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1695      +/-   ##
===========================================
- Coverage    83.73%   83.69%   -0.04%     
===========================================
  Files          463      463              
  Lines        15896    15893       -3     
  Branches      2371     2370       -1     
===========================================
- Hits         13310    13301       -9     
  Misses        1951     1951              
- Partials       635      641       +6

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@plousada
plousada merged commit 9a80cf9 into develop Nov 13, 2023
@plousada
plousada deleted the plousada/include_rum_mobile_android_codeowner branch November 13, 2023 16:33
@xgouchet xgouchet mentioned this pull request Nov 15, 2023
Closed
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@plousada @codecov-commenter @xgouchet @mariusc83 @0xnm @jonathanmos