RUM-1924: Use tracestate header to supply vendor-specific information#1694
Merged
0xnm merged 1 commit intoNov 14, 2023
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-1924/use-tracestate-to-supply-vendor-specific-information
branch
from
November 13, 2023 10:18
0d92e7a to
c4a7806
Compare
mariusc83
reviewed
Nov 13, 2023
mariusc83
approved these changes
Nov 13, 2023
jonathanmos
approved these changes
Nov 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1694 +/- ##
===========================================
- Coverage 83.73% 83.59% -0.14%
===========================================
Files 463 463
Lines 15896 15934 +38
Branches 2371 2377 +6
===========================================
+ Hits 13310 13319 +9
- Misses 1951 1978 +27
- Partials 635 637 +2
|
xgouchet
approved these changes
Nov 13, 2023
0xnm
deleted the
nogorodnikov/rum-1924/use-tracestate-to-supply-vendor-specific-information
branch
November 14, 2023 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
tracestateheader with Datadog-specific information in case ofTRACECONTEXTtracing. This header will contain the following Datadog-specific tags:p- parent IDs- sampling decisiono- origin, if exists. In case of instrumentation with RUM, it will haverumvalue.Full spec https://www.w3.org/TR/trace-context/#tracestate-header
iOS counterpart DataDog/dd-sdk-ios#1536
Review checklist (to be filled by reviewers)