RUM-2104: Fix the issue of missing cpu/memory info with RUM view events#1693
Merged
0xnm merged 1 commit intoNov 10, 2023
Merged
Conversation
plousada
approved these changes
Nov 9, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1693 +/- ##
===========================================
- Coverage 83.70% 83.69% -0.01%
===========================================
Files 463 463
Lines 15889 15887 -2
Branches 2371 2369 -2
===========================================
- Hits 13299 13296 -3
- Misses 1947 1959 +12
+ Partials 643 632 -11
|
xgouchet
approved these changes
Nov 10, 2023
mariusc83
approved these changes
Nov 10, 2023
0xnm
deleted the
nogorodnikov/rum-2104/memory-and-cpu-info-is-not-sent
branch
November 10, 2023 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RUM data was missing cpu/memory info since SDK v2, because we were safe-casting the property of RUM context to the wrong type.
Review checklist (to be filled by reviewers)