RUM-1492 Have more consistent results when using the load picture sample screen#1692
Merged
xgouchet merged 1 commit intoNov 9, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1692 +/- ##
===========================================
- Coverage 83.76% 83.63% -0.13%
===========================================
Files 462 462
Lines 15858 15855 -3
Branches 2366 2365 -1
===========================================
- Hits 13282 13259 -23
- Misses 1939 1963 +24
+ Partials 637 633 -4 |
0xnm
approved these changes
Nov 9, 2023
xgouchet
deleted the
xgouchet/RUM-1492/have_more_consistent_successful_image_loading
branch
November 9, 2023 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To ensure our E2E tests have a consistent number of event, while having some picture load failure, we replace the "pure" random logic with alternating loading failure and success