RUM-1492 Improve Logs Fragment in sample App#1685
Merged
Merged
Conversation
xgouchet
marked this pull request as ready for review
November 2, 2023 11:42
Codecov Report
@@ Coverage Diff @@
## develop #1685 +/- ##
===========================================
- Coverage 83.73% 83.72% -0.01%
===========================================
Files 462 462
Lines 15855 15855
Branches 2365 2365
===========================================
- Hits 13275 13274 -1
- Misses 1939 1947 +8
+ Partials 641 634 -7 |
0xnm
reviewed
Nov 2, 2023
| ) | ||
| R.id.log_critical -> logger.wtf( | ||
| "User triggered a critical event", | ||
| UnsupportedOperationException("Oops") |
Member
There was a problem hiding this comment.
having exceptions sent was a nice scenario to test symbolication/error handling outside of crashes, should we maybe still send them?
Contributor
Author
There was a problem hiding this comment.
Good point, I'll add it back
xgouchet
force-pushed
the
xgouchet/RUM-1492/update_sample_app_for_E2E
branch
from
November 2, 2023 13:09
5868187 to
d6ca201
Compare
0xnm
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a better way to send logs from the sample app
Motivation
Being able to have more control from the Synthetics Tests
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)