RUM-1613 Add mapper interface for traversing all children#1684
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-1613/traversal-mapper
branch
2 times, most recently
from
November 1, 2023 09:29
0838ea9 to
74f29b3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1684 +/- ##
===========================================
+ Coverage 83.73% 83.79% +0.06%
===========================================
Files 459 459
Lines 15778 15781 +3
Branches 2354 2355 +1
===========================================
+ Hits 13211 13223 +12
+ Misses 1938 1933 -5
+ Partials 629 625 -4
|
jonathanmos
marked this pull request as ready for review
November 1, 2023 10:08
mariusc83
requested changes
Nov 2, 2023
jonathanmos
changed the base branch from
louiszawadzki/poc-cross-platform-session-replay
to
develop
November 2, 2023 09:46
jonathanmos
marked this pull request as draft
November 2, 2023 09:47
jonathanmos
force-pushed
the
jmoskovich/rum-1613/traversal-mapper
branch
2 times, most recently
from
November 2, 2023 18:55
9c42246 to
bd90c68
Compare
jonathanmos
marked this pull request as ready for review
November 2, 2023 19:34
xgouchet
reviewed
Nov 3, 2023
Comment on lines
+47
to
+48
| traversalStrategy = if (mapper is NonExhaustiveTypeMapper) { | ||
| TraversalStrategy.TRAVERSE_ALL_CHILDREN |
Contributor
There was a problem hiding this comment.
Note
I'm confused about the naming of the interface: It says the mapper is Non exhaustive, but it would imply using a TRAVERSE_ALL_CHILDREN strategy. Can we be a bit more explicit about what is being non exhaustive here?
Member
Author
There was a problem hiding this comment.
Until now we've referred to mappers that return a node whenever they map to a specific class as being "exhaustive", and so the naming follows from this. How about "TraverseAllChildrenMapper"?
jonathanmos
force-pushed
the
jmoskovich/rum-1613/traversal-mapper
branch
3 times, most recently
from
November 7, 2023 08:54
a839f65 to
0ca6379
Compare
xgouchet
approved these changes
Nov 7, 2023
louiszawadzki
approved these changes
Nov 7, 2023
mariusc83
approved these changes
Nov 7, 2023
jonathanmos
force-pushed
the
jmoskovich/rum-1613/traversal-mapper
branch
from
November 7, 2023 14:02
0ca6379 to
8147727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an internal interface for mappers that need to traverse all children during tree traversal.
Motivation
This interface is to be used by React Native for traversing RN view groups, as preparation for implementing Session Replay there.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)