feat: Make NDK stack traces more standard#1683
Merged
Merged
Conversation
This changes the stack frame format to:
```
#{frame_number} pc {relative_address} {module_name} ({symbol_name}+{symbol_offset})
```
This is a more standard format of stack traces seen in examples and Android tombstones.
Also remove a few extra object creations / memory allocations.
refs: RUM-1896
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1683 +/- ##
===========================================
+ Coverage 83.73% 83.76% +0.03%
===========================================
Files 462 462
Lines 15855 15855
Branches 2365 2365
===========================================
+ Hits 13275 13280 +5
- Misses 1939 1942 +3
+ Partials 641 633 -8 🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
Oct 31, 2023
xgouchet
previously approved these changes
Oct 31, 2023
…er.cpp Co-authored-by: Nikita Ogorodnikov <[email protected]>
xgouchet
previously approved these changes
Oct 31, 2023
mariusc83
requested changes
Oct 31, 2023
mariusc83
previously approved these changes
Oct 31, 2023
xgouchet
approved these changes
Nov 2, 2023
mariusc83
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the stack frame format to:
This is a more standard format of stack traces seen in examples and Android tombstones.
Also remove a few extra object creations / memory allocations.
refs: RUM-1896
Motivation
We're looking to start work on NDK crash symbolication and wanted a format that matched with what is in other examples. While the previous format has all the information we needed for symbolication, it wasn't quite right about what was offset by what. This is a more correct format.
Review checklist (to be filled by reviewers)