Share RawBatchEvent forgery for tests between the modules#1680
Merged
0xnm merged 1 commit intoOct 26, 2023
Conversation
mariusc83
previously approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline #1680 +/- ##
==============================================================================================
- Coverage 83.71% 83.66% -0.05%
==============================================================================================
Files 462 462
Lines 15843 15840 -3
Branches 2363 2362 -1
==============================================================================================
- Hits 13262 13252 -10
- Misses 1943 1948 +5
- Partials 638 640 +2 |
Base automatically changed from
nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline
to
develop
October 26, 2023 09:47
0xnm
dismissed stale reviews from xgouchet and mariusc83
October 26, 2023 09:47
The base branch was changed.
xgouchet
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just a minor improvement to share
RawBatchEventforgery, so that is can be used in tests in different modules.Review checklist (to be filled by reviewers)