Skip to content

RUM-1517 Add test pyramid scaffolding#1674

Merged
xgouchet merged 3 commits into
developfrom
xgouchet/RUM-1517/test_pyramid_scaffolding
Oct 17, 2023
Merged

RUM-1517 Add test pyramid scaffolding#1674
xgouchet merged 3 commits into
developfrom
xgouchet/RUM-1517/test_pyramid_scaffolding

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Creates the scaffolding for our Single Feature Integration Test level from our Test Pyramid strategy.

@xgouchet
xgouchet requested a review from a team as a code owner October 16, 2023 16:07
@xgouchet
xgouchet force-pushed the xgouchet/RUM-1517/test_pyramid_scaffolding branch from ca1db6b to 4894f88 Compare October 16, 2023 16:26
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1674 (4894f88) into develop (cbdf622) will increase coverage by 0.15%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1674      +/-   ##
===========================================
+ Coverage    83.58%   83.73%   +0.15%     
===========================================
  Files          459      459              
  Lines        15778    15775       -3     
  Branches      2354     2353       -1     
===========================================
+ Hits         13187    13208      +21     
+ Misses        1956     1938      -18     
+ Partials       635      629       -6     

see 24 files with indirect coverage changes

Comment thread .gitlab-ci.yml Outdated
test-pyramid:single-fit-logs:
tags: [ "runner:main" ]
image: $CI_IMAGE_DOCKER
stage: test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be test-pyramid here and below? Or it should stay test until this stage is completely replaced by test-pyramid?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is empty manifest needed? I guess since we are using namespace in build.gradle.kts, it is not useful. Same applies to other manifest files added in this PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed or the compiler complains

Comment on lines +38 to +39
api(project(":dd-sdk-android-core"))
api(project(":features:dd-sdk-android-logs"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be implementation here? api is for re-export, which is not needed.

Comment on lines +38 to +39
api(project(":dd-sdk-android-core"))
api(project(":features:dd-sdk-android-rum"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
api(project(":dd-sdk-android-core"))
api(project(":features:dd-sdk-android-rum"))
implementation(project(":dd-sdk-android-core"))
implementation(project(":features:dd-sdk-android-rum"))

Comment on lines +38 to +39
api(project(":dd-sdk-android-core"))
api(project(":features:dd-sdk-android-trace"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
api(project(":dd-sdk-android-core"))
api(project(":features:dd-sdk-android-trace"))
implementation(project(":dd-sdk-android-core"))
implementation(project(":features:dd-sdk-android-trace"))

mariusc83
mariusc83 previously approved these changes Oct 17, 2023

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xgouchet
xgouchet merged commit 4744e9d into develop Oct 17, 2023
@xgouchet
xgouchet deleted the xgouchet/RUM-1517/test_pyramid_scaffolding branch October 17, 2023 09:48
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants