RUM-1578: Support returning event metadata to the readers#1670
Merged
0xnm merged 1 commit intoOct 16, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1670 +/- ##
===========================================
- Coverage 83.73% 83.62% -0.11%
===========================================
Files 459 459
Lines 15778 15770 -8
Branches 2354 2360 +6
===========================================
- Hits 13211 13187 -24
- Misses 1938 1946 +8
- Partials 629 637 +8
|
0xnm
force-pushed
the
nogorodnikov/rum-1578/support-returning-event-metadata-to-readers
branch
2 times, most recently
from
October 13, 2023 08:25
89558b4 to
4310c12
Compare
0xnm
force-pushed
the
nogorodnikov/rum-1578/support-returning-event-metadata-to-readers
branch
from
October 13, 2023 08:56
4310c12 to
e08208d
Compare
xgouchet
approved these changes
Oct 16, 2023
mariusc83
approved these changes
Oct 16, 2023
0xnm
deleted the
nogorodnikov/rum-1578/support-returning-event-metadata-to-readers
branch
October 16, 2023 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a pre-requisite for the change where we are going to reduce RUM views on the client side.
This PR looks big, but what is does essentially is just shifting the responsibility of the event metadata generation to the feature side (change the signature of
writeDatato accept newly created classRawBatchEvent(data, meta)), and also makesreadDatato return this pair of event data +metadata, so that they can be later processed in the upload pipeline.Signature change of the upload pipeline is similar to what was done in https://github.com/DataDog/dd-sdk-ios/pull/1328/files#diff-a6e4927f6142a31326e45af76631e0538c32b90f419b8856e5d4bad1ecfa99c0.
The structure of
RawBatchEventis similar to https://github.com/DataDog/dd-sdk-ios/pull/1328/files#diff-6e6d2fa1d307e2172f3a6a08142a5f78106dbe374927ba3da5926deb33decbacReview checklist (to be filled by reviewers)