(3/3) RUM-392 let all modules use the shared fixtures#1668
Merged
Conversation
0xnm
previously approved these changes
Oct 12, 2023
| } | ||
| } | ||
| testImplementation(testFixtures(project(":dd-sdk-android-core"))) | ||
| testImplementation(libs.okHttp) |
mariusc83
previously approved these changes
Oct 12, 2023
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
Nicely done, thank you for this ;)
xgouchet
force-pushed
the
xgouchet/RUM-392/2_shared_core_fixtures
branch
4 times, most recently
from
October 16, 2023 09:39
2c2668e to
3de4864
Compare
Base automatically changed from
xgouchet/RUM-392/2_shared_core_fixtures
to
develop
October 16, 2023 11:59
xgouchet
dismissed stale reviews from mariusc83 and 0xnm
October 16, 2023 11:59
The base branch was changed.
xgouchet
force-pushed
the
xgouchet/RUM-392/3_shared_core_fixtures
branch
from
October 16, 2023 12:01
8fb224b to
75949ff
Compare
0xnm
previously approved these changes
Oct 16, 2023
xgouchet
force-pushed
the
xgouchet/RUM-392/3_shared_core_fixtures
branch
from
October 16, 2023 12:46
75949ff to
a470a07
Compare
0xnm
approved these changes
Oct 16, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1668 +/- ##
===========================================
- Coverage 83.71% 83.69% -0.02%
===========================================
Files 459 459
Lines 15778 15775 -3
Branches 2354 2353 -1
===========================================
- Hits 13208 13202 -6
- Misses 1943 1948 +5
+ Partials 627 625 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR lets each feature module to use the core module's
testFixturessource setsMotivation
This is part of our effort on improving our test suites across the mobile teams