(2/3) RUM-392 refactor shared android library build script#1667
Conversation
d94a25d to
eea183c
Compare
There was a problem hiding this comment.
In the future probably it will be better to switch from buildSrc to the composite build usage (like mobile app is doing). I tried to do a quick migration, but then the problem is that some extension symbols are not available and the only way to make things work is to re-write everything to plugins, which is quite a work.
There was a problem hiding this comment.
That might be an idea, we need to see the pros and cons of that. A quick read on the composite build docs left a lot of questions, so I think this might be better addressed as an exploration/ADR.
d006017 to
172b18f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1667 +/- ##
===========================================
- Coverage 83.73% 83.71% -0.02%
===========================================
Files 459 459
Lines 15778 15778
Branches 2354 2354
===========================================
- Hits 13211 13208 -3
- Misses 1938 1943 +5
+ Partials 629 627 -2 |
The base branch was changed.
172b18f to
2c2668e
Compare
0xnm
left a comment
0xnm
left a comment
There was a problem hiding this comment.
it seems few apiSurface files should are deleted by some occasion, they should be restored.
2c2668e to
3de4864
Compare
4 participants
What does this PR do?
This PR refactor the
build.gradle.ktsbuildscript for all our libraries to extract shared configurations and make it easier to:Motivation
This is part of our effort on improving our test suites across the mobile teams