(1/3) RUM-392 create core testFixtures source set#1666
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-392/1_shared_core_fixtures
branch
from
October 12, 2023 05:17
3cfe65f to
d94a25d
Compare
xgouchet
force-pushed
the
xgouchet/RUM-392/1_shared_core_fixtures
branch
from
October 12, 2023 06:30
d94a25d to
eea183c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1666 +/- ##
===========================================
- Coverage 83.73% 83.72% -0.01%
===========================================
Files 459 459
Lines 15778 15775 -3
Branches 2354 2353 -1
===========================================
- Hits 13211 13207 -4
Misses 1938 1938
- Partials 629 630 +1 🚀 New features to boost your workflow:
|
0xnm
approved these changes
Oct 12, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
just two minor questions, otherwise lgtm.
mariusc83
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
testFixturessource set to the Core module, and adds test fixture classes that will be shared with other modues (in the next PR)Motivation
This is part of our effort on improving our test suites across the mobile teams