Disable warning as errors locally#1664
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1664 +/- ##
===========================================
- Coverage 83.64% 83.53% -0.11%
===========================================
Files 458 458
Lines 15767 15764 -3
Branches 2354 2353 -1
===========================================
- Hits 13187 13167 -20
- Misses 1946 1969 +23
+ Partials 634 628 -6 |
mariusc83
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
CIenvironment variable to enable the "show warning as errors" in Kotlin compilerMotivation
During development, especially when doing TDD, I often find myself having variables/parameters temporarily unused, which prevent from running the tests.
This new option allows me to to TDD without manually changing the
allWarningsAsErrorsand still keep checks in the CI.Note
The
local_ci.shscript will set the environnement variable to ensure one can detect those warnings before pushing to CI