RUM-501 Handle Android Strict Mode#1663
Merged
Merged
Conversation
0xnm
previously approved these changes
Oct 9, 2023
| * @param operation the operation | ||
| * @return the value returned by the operation | ||
| */ | ||
| fun <T> allowThreadDiskReads( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1663 +/- ##
===========================================
+ Coverage 83.64% 83.68% +0.05%
===========================================
Files 458 459 +1
Lines 15767 15775 +8
Branches 2354 2353 -1
===========================================
+ Hits 13187 13201 +14
+ Misses 1946 1945 -1
+ Partials 634 629 -5
🚀 New features to boost your workflow:
|
mariusc83
previously approved these changes
Oct 9, 2023
xgouchet
force-pushed
the
xgouchet/RUM-501/strict_mode
branch
from
October 9, 2023 11:48
ac07eec to
edb5195
Compare
0xnm
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This tries to handle some StrictMode warnings happening during the SDK initialization, which can't easily be deferred to background threads.
Motivation
Prevent the SDK from spamming warnings in host application when StrictMode feature is enabled.