Update testing conventions#1661
Merged
Merged
Conversation
xgouchet
marked this pull request as ready for review
October 4, 2023 14:50
0xnm
reviewed
Oct 5, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
looks good! I've added some questions/suggestions
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 3782478 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
==========================================
Coverage ? 83.67%
==========================================
Files ? 458
Lines ? 15767
Branches ? 2354
==========================================
Hits ? 13192
Misses ? 1951
Partials ? 624 🚀 New features to boost your workflow:
|
xgouchet
force-pushed
the
xgouchet/update_testing_conventions
branch
from
October 5, 2023 11:05
0ea2e9e to
df0d87f
Compare
jonathanmos
previously approved these changes
Oct 6, 2023
0xnm
previously approved these changes
Oct 6, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
minor suggestion only, otherwise lgtm
xgouchet
force-pushed
the
xgouchet/update_testing_conventions
branch
from
October 6, 2023 10:37
df0d87f to
41e7a50
Compare
0xnm
previously approved these changes
Oct 6, 2023
xgouchet
force-pushed
the
xgouchet/update_testing_conventions
branch
from
October 6, 2023 11:34
41e7a50 to
3782478
Compare
0xnm
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up after today's meeting to improve our testing guidelines.